Detection - #1152
Merged
Merged
Conversation
|
@Qoder-Undefined Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the e2e coverage for the email API: no end-to-end spec exercises send, templates, or unsubscribe
Add e2e coverage for the email API: no end-to-end spec exercises send, templates, or unsubscribe
Labels / Complexity: testing · Medium Complexity — Medium
Problem
The test/e2e/ suite has no spec for the email API. The email module renders templates, sends messages, and handles unsubscribe links — including the localhost:3000 fallback already flagged (#41). There is no HTTP-level test pinning template rendering or the unsubscribe URL contract, so a regression in either ships silently.
closes #1067
closes #1068
closes #1069
closes #1066