Webhook api - #1151
Merged
Merged
Conversation
|
@Nanafancy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the e2e coverage for the webhook API: no end-to-end spec exercises registration, signing, and delivery
Labels / Complexity: testing · Medium Complexity — Medium
Problem
The test/e2e/ suite has no spec for the webhook API. Webhook registration, challenge verification, and signed delivery are the integration contract external consumers depend on, and they are only fragmentarily unit-covered (#98). A regression that breaks signature verification or delivery ships silently — consumers receive unverifiable or missing payloads.
closes #1071
closes #1072
closes #1073
closes #1077