Remove @ts-nocheck: auth, users, transactions, properties - #1144
Merged
nanaf6203-bit merged 62 commits intoAug 26, 2026
Conversation
Restore strict type checking to these modules and fix the errors it surfaced (missing await on queue lookup, unknown catch types, non-existent DocumentBuilder.setOpenAPI, broken AuditService import → PrismaService). Closes MettaChain#1038 Closes MettaChain#1039 Closes MettaChain#1040 Closes MettaChain#1041 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
…ations Restore strict type checking and fix surfaced errors: sync FraudPattern enum with the Prisma schema, type unknown catch errors, remove a duplicate/buggy gateway sendToUser, fix a blockchainHash field typo and a preferences cast. Closes MettaChain#1034 Closes MettaChain#1035 Closes MettaChain#1036 Closes MettaChain#1037 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
…losed blockchain - RateLimitAdminController: require authenticated ADMIN (JwtAuthGuard+RolesGuard) (MettaChain#1018) - AvatarUploadController: require authentication on all routes (MettaChain#1019) - TrackingController: validate redirect scheme + host allow-list (fail closed) (MettaChain#1020) - BlockchainService: refuse placeholder RPC URL; run disabled when unset (MettaChain#1021) Closes MettaChain#1018 Closes MettaChain#1019 Closes MettaChain#1020 Closes MettaChain#1021 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
…-detection tests - Remove @ts-nocheck from documents and search; type the search-filter builder (range/select/date filters) and fix an unawaited async filter combination (MettaChain#1026, MettaChain#1027) - Add AnalyticsService unit tests (normal/empty/invalid window) (MettaChain#1029) - Add DuplicateDetectionService text-similarity unit tests (exact/near/distinct) (MettaChain#1028) Closes MettaChain#1026 Closes MettaChain#1027 Closes MettaChain#1028 Closes MettaChain#1029 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
Restore strict type checking to the four largest modules and fix the surfaced errors: complete SearchPropertiesDto (sort/geo/category fields), narrow i18n language args, inject PrismaService in property-expiry, type unknown catch errors and header values, import redactEmail, and de-TypeORM a dead entity. Closes MettaChain#1022 Closes MettaChain#1023 Closes MettaChain#1024 Closes MettaChain#1025 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
|
@tolulopedd26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The @UseGuards(JwtAuthGuard) added to AvatarUploadController requires AuthService in the DI container. Without this mock, NestJS fails to compile the test module.
…port-tickets.controller.ts
…port-tickets.module.ts
…port-tickets.service.ts
…/support-ticket.dto.ts
nanaf6203-bit
approved these changes
Aug 26, 2026
nanaf6203-bit
left a comment
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thanks for getting this over the line!
…-1056-1057 Remove @ts-nocheck from commissions and support-tickets, fix audit storage and unsubscribe URL
…1058-1059-1060-1061 Add database and support-tickets tests, remove @ts-nocheck from email and property-views
…-1064-1065 Add unit and e2e test coverage for backup, content, search, and email modules
…51-1052-1053 Remove example controllers, add content auth guard, add metrics and email-digest tests
…1044-1045 Add unit tests for property-comparison, sessions, open-house, and neighborhoods modules
…046-1047-1048-1049 Add unit tests for integrations, favorites, dashboard, and archive modules
…earch-nocheck-analytics-dup-tests documents/search @ts-nocheck removal + analytics/dup-detection tests
…y-auth-openredirect-blockchain-default Security: admin/avatar auth, open-redirect fix, blockchain fail-closed
…emove-ts-nocheck-openhouse-fraud-notif-integrations Remove @ts-nocheck: open-house, fraud, notifications, integrations
…ts-nocheck-config-admin-trust-email Remove @ts-nocheck: config, admin, trust-score, email-digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
@ts-nocheckfrom the auth, users, transactions, and properties modules (94 files) and fixes the strict-mode errors it surfaced. No behaviour change.Remaining repo-wide
@ts-nocheckcount after this PR: 170.Closes #1022
Closes #1023
Closes #1024
Closes #1025