documents/search @ts-nocheck removal + analytics/dup-detection tests - #1143
Merged
nanaf6203-bit merged 1 commit intoAug 26, 2026
Conversation
…-detection tests - Remove @ts-nocheck from documents and search; type the search-filter builder (range/select/date filters) and fix an unawaited async filter combination (MettaChain#1026, MettaChain#1027) - Add AnalyticsService unit tests (normal/empty/invalid window) (MettaChain#1029) - Add DuplicateDetectionService text-similarity unit tests (exact/near/distinct) (MettaChain#1028) Closes MettaChain#1026 Closes MettaChain#1027 Closes MettaChain#1028 Closes MettaChain#1029 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
|
@TomikeDS Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Aug 26, 2026
nanaf6203-bit
left a comment
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thanks for getting this over the line!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
@ts-nocheckfrom the documents and search modules and adds unit tests for the analytics and duplicate-detection services.Remaining repo-wide
@ts-nocheckcount after this PR: 236.Closes #1026
Closes #1027
Closes #1028
Closes #1029