Security: admin/avatar auth, open-redirect fix, blockchain fail-closed - #1142
Merged
nanaf6203-bit merged 2 commits intoAug 26, 2026
Conversation
…losed blockchain - RateLimitAdminController: require authenticated ADMIN (JwtAuthGuard+RolesGuard) (MettaChain#1018) - AvatarUploadController: require authentication on all routes (MettaChain#1019) - TrackingController: validate redirect scheme + host allow-list (fail closed) (MettaChain#1020) - BlockchainService: refuse placeholder RPC URL; run disabled when unset (MettaChain#1021) Closes MettaChain#1018 Closes MettaChain#1019 Closes MettaChain#1020 Closes MettaChain#1021 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NJauhMw3eEcE45J1hUX2aZ
|
@temiport25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The @UseGuards(JwtAuthGuard) added to AvatarUploadController requires AuthService in the DI container. Without this mock, NestJS fails to compile the test module.
nanaf6203-bit
approved these changes
Aug 26, 2026
nanaf6203-bit
left a comment
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thanks for getting this over the line!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four security fixes:
Closes #1018
Closes #1019
Closes #1020
Closes #1021