Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/metricshub/wmi/WmiStringConverter.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ public WmiStringConverter() {
* Convert the specified value/object to a string:
* <ul>
* <li>OffsetDateTime: to number of seconds since Epoch, or standard English date/time
* <li>Array: items separated with specified <em>arraySeparator</em>
* <li>Array: items joined with the specified <em>arraySeparator</em>, which is removed from
* each item (<code>a|b</code>, <code>a</code> for a single item, an empty string for an empty array)
* <li>null: empty string
* <li>Boolean: True or False
* <li>Anything else: using <code>String.valueOf()</code>
Expand All @@ -96,7 +97,7 @@ public String convert(Object value) {
.of((Object[]) value)
.map(this::convert)
.map(item -> item.replace(arraySeparator, Utils.EMPTY))
.collect(Collectors.joining(arraySeparator, Utils.EMPTY, arraySeparator));
.collect(Collectors.joining(arraySeparator));
}

if (value instanceof String) {
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/org/metricshub/wmi/WmiStringConverterTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package org.metricshub.wmi;

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.Test;

class WmiStringConverterTest {

@Test
void testConvertArray() {
final WmiStringConverter converter = new WmiStringConverter();
assertEquals("192.0.2.10|fe80::1", converter.convert(new String[] { "192.0.2.10", "fe80::1" }));
assertEquals("fr-FR", converter.convert(new String[] { "fr-FR" }));
assertEquals("", converter.convert(new String[0]));
assertEquals("", converter.convert(null));
assertEquals("ab|c", converter.convert(new String[] { "a|b", "c" }));
assertEquals("2|True", converter.convert(new Object[] { 2, Boolean.TRUE }));
assertEquals("a, b", new WmiStringConverter(", ", true).convert(new String[] { "a", "b" }));
}
}
Loading