Repository navigation
Accept multi-line WHERE clauses in WQL queries - #192
Merged
bertysentry merged 1 commit intoSep 29, 2026
Merged
bertysentry merged 1 commit into
bertysentry merged 1 commit into
Conversation
WmiHelper.WQL_SIMPLE_SELECT_PATTERN was compiled without Pattern.DOTALL, so `.*` in the optional WHERE group stopped at the first line break and queries written as text blocks were rejected with WqlSyntaxException. The legacy WqlQuery pattern already had DOTALL and is unaffected. Fixes #190 Co-Authored-By: Claude Fable 5.1 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8d164e716
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bertysentry
deleted the
190-wql-queries-with-a-multi-line-where-clause-are-rejected-with-wqlsyntaxexception
branch
September 29, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190.
WmiHelper.WQL_SIMPLE_SELECT_PATTERNwas compiled withCASE_INSENSITIVEonly, so the.*of the optionalWHEREgroup stopped at the first line break and a query such aswas rejected with
WqlSyntaxExceptionbefore anything was sent. AddingPattern.DOTALLlets line breaks appear wherever whitespace is, without loosening the grammar otherwise:ASSOCIATORS OF,REFERENCES OF, event queries and multipleSELECTs are still rejected.The legacy
WqlQuerypattern already usedDOTALL, so it is unaffected.WmiHelperTestcovers the three cases from the issue (plus CRLF) and the rejections; the multi-line case fails without the fix.wql.mdnotes that line breaks are accepted, so text blocks work as is.🤖 Generated with Claude Code