Repository navigation
Review the documentation before the 2.3.00 release - #187
Conversation
A full pass over src/site/markdown, site.xml and README.md, checked against the code: every finding was verified in the source before being applied. - Correct wrong statements: WQL row values are always strings (a WMI NULL is an empty string), getFaultCode() returns a String, client-side Kerberos failures are a plain WinRMClientException, the legacy API no longer detects the output code page, --https-permissive does not set the insecure system property, PowerShell can be 2.0 on old hosts, and Basic must not be combined with --https-permissive. - Document what was missing: the builder options and their defaults (a new "Client options" table on the overview, which two pages already pointed to), thread sharing, the Kerberos principal and ticket-cache rules, and the 1.x breaking changes the migration page left out. - Tighten the structure: File Transfers covers uploads and how downloads work, Remote Files no longer repeats it; CLI option tables on topic pages become pointers to cli.md; repeated exception tables and implementation rationale are trimmed. - Make it consistent: 2.0.00 version notation, lowercase anchors, the JDK trust store wording. - Fix the --help text (DOMAIN\user printed with two backslashes, the "Connection options" header, the -i line) and stale Javadoc. - README: current feature list and release instructions. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ad7cb2cb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- authentication.md: the client strips all whitespace from the user name (WinRMEndpoint), so a qualified Basic name is not sent unchanged. - file-transfers.md: the 30-day purge only covers the transfer-and-run directory; leftovers next to an uploadFile(...) destination stay. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@codex please review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c3cbb32b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Only arguments containing whitespace or a double quote are quoted, so the remote cmd.exe interprets &, |, <, >, ^ and % in the others. Say so instead of promising that each argument stays one word. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@codex please review again |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A pre-release review of the whole site (
src/site/markdown/*.md,site.xml) and README, to make the 2.3.00 docs accurate, complete, consistent and no longer than needed. The pages come out slightly shorter overall (+526 / −530).How it was reviewed
Twelve reviewers each covered either a group of pages, checked against the source, or a cross-cutting angle: API coverage, links and structure, a newcomer reading in menu order, and compiling every code example. That produced 361 findings. A skeptical verifier per file then re-checked each finding in the code: 179 were confirmed, 30 refuted and 152 duplicates. 176 are applied here, and every edit was re-checked per file and read in full.
What changed
Wrong statements corrected
NULLcomes back as an empty string (get()is not a typed value).WinRMFaultException.getFaultCode()returns aStringthat can benull.WinRMAuthenticationException. A client-side Kerberos failure (KDC, SPN, clock skew) is a plainWinRMClientException(authentication, timeouts-and-errors, preparing-the-host).--https-permissivesets the insecure system property. It callstrustAllCertificates().waitFor(Duration)comment suggested code that does not compile (it returns aboolean).SELECT *columns are alphabetical.--https-permissive, which hands the password to any impostor host.Missing coverage added
DOMAIN\part of the user name is ignored (useuser@REALM). WithticketCache(...),credentials(...)is still required and must name the cached principal./switcharguments;wqlalways queriesROOT\CIMV2.Structure and consistency
#Privilegesand the like) are now lowercase-hyphen. "Platform trust store" becomes the JDK'scacerts.CLI help and Javadoc
--helpprintedDOMAIN\\userwith two backslashes. Copied as-is, that user name fails to authenticate.-iline implied stdin is only forwarded with-i. Forwarding is automatic when stdin is redirected;-iforces it.CommandRequest.stdinCharset;WinRMCommandExecutorexample, which named a class that does not exist and passed the wrong arguments;WqlResult.columns();WindowsRemoteCommandResult: execution time is in seconds, and the missing@returndescriptions are added.README
Only wrong or stale content is corrected: the feature list, the release instructions (Central Portal with auto-release, not OSSRH/Nexus staging), and two outdated option paragraphs, now replaced by a link to the site.
For the reviewer
site.xmlis unchanged: the menu was reviewed and found fine.stream(),start(),openStream()) can leak a rawIllegalStateExceptionfor protocol failures (LightWinRMService.callStreaming). The docs keep promisingWinRMClientException, so the code should be fixed.WsmanClient.collectRows). wql.md does not mention arrays until this is fixed.WHEREclause is rejected locally (WmiHelperpattern withoutDOTALL).mvn clean verify sitepasses: 322 tests, no checkstyle/PMD/SpotBugs findings. A script over the generated site found no broken internal link or anchor.🤖 Generated with Claude Code