Repository navigation
Issue #60 Create offline SNMP client - #65
Merged
Merged
Conversation
MedMaalej
commented
Aug 27, 2025
MedMaalej
commented
Contributor
- Develop OfflineSnmpFileClient
- Add a unified abstraction (interface) that both SnmpClient and OfflineSnmpClient can implement
* Develop a new client for testing in emulation mode
…ssue-60-Create-offline-snmp-client
NassimBtk
reviewed
Sep 2, 2025
|
|
||
| @Override | ||
| public String walk(String oid) { | ||
| return ""; |
Contributor
There was a problem hiding this comment.
We ca n return the full result here from this oid.
| import java.util.NavigableMap; | ||
| import java.util.TreeMap; | ||
|
|
||
| public final class OfflineSnmpFileClient implements ISnmpClient { |
| */ | ||
| public interface ISnmpClient { | ||
|
|
||
| /** SNMP <em>GET</em>. */ |
| /** SNMP <em>GET</em>. */ | ||
| String get(String oid) throws Exception; | ||
|
|
||
| /** SNMP <em>GETNEXT</em>. */ |
| return s.startsWith(".") ? s.substring(1) : s; | ||
| } | ||
|
|
||
| String walk(String oid) throws Exception; |
* Update code after review * Add unit test
…ssue-60-Create-offline-snmp-client
MedMaalej
force-pushed
the
feature/issue-60-Create-offline-snmp-client
branch
from
September 4, 2025 08:26
db77a4a to
6628aa5
Compare
* Refactor code and add missing final keyword
MedMaalej
requested review from
CherfaElyes,
MarcDouguedroit,
NassimBtk,
SafaeAJ,
TNohaic and
bertysentry
September 4, 2025 08:37
MedMaalej
marked this pull request as ready for review
September 4, 2025 08:37
* Rename the client * Iterate on the walk file directory * Update the tests
MedMaalej
force-pushed
the
feature/issue-60-Create-offline-snmp-client
branch
from
September 15, 2025 13:23
da29480 to
0fb4716
Compare
NassimBtk
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.