Repository navigation
Issue #69 - Build the site with Doxia 2 - #70
Merged
Merged
Conversation
oss-parent configures maven-site-plugin 3.12.1 with maven-skin-tools 1.3.00, which puts Velocity 1.7 / velocity-tools 2.0 and Velocity 2.3 / velocity-tools 3.1 on the plugin class path. Maven 3.10 orders that class path differently from Maven 3.9 and mixes them, so the site fails with an AbstractMethodError on org.apache.velocity.tools.ToolContext. Use maven-site-plugin 4.0.0-M16 with maven-skin-tools 1.8.01 (Doxia 2, one Velocity generation), and the SITE 2.0.0 descriptor with sentry-maven-skin 8.0.00, as community-connectors does. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 8, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
What changed
Build the site with Doxia 2, as community-connectors does:
pom.xml:maven-site-plugin4.0.0-M16 withorg.sentrysoftware.maven:maven-skin-tools1.8.01.oss-parent5 still configures 3.12.1 withmaven-skin-tools1.3.00.src/site/site.xml: the SITE 2.0.0 format withsentry-maven-skin8.0.00. The content is unchanged: same banner, links and menus.®becomes®, because the 2.0.0 descriptor is plain XML.Why
On runners with Maven 3.10.0 (image
ubuntu24/20261004and later),mvn sitefails withAbstractMethodError: Receiver class org.apache.velocity.tools.ToolContext does not define or inherit an implementation of ... remove(java.lang.Object) of interface org.apache.velocity.context.Context.The site plugin class path holds two generations of Velocity with the same packages:
doxia-site-renderer1.11.1;maven-skin-tools1.3.00.Maven 3.9 put the Velocity 2 jars first (realm positions 3-4, before the 1.7 jars at 103-106). Maven 3.10 interleaves them (tools-generic 3.1 at 28, Velocity 1.7 at 48, velocity-engine-core 2.3 at 57), so
ToolContextandContextcome from different generations. With Doxia 2, only Velocity 2 is left, and the order no longer matters. Details in the issue.Validation
mvn clean verify site, from a plain clone, with empty settings and JDK 17:css/main-combined.css, logo, menus, Javadoc)Before this change, Maven 3.10.0 reproduced the
AbstractMethodErrorlocally.From a git worktree, the
maven-changelog-pluginreport fails because JGit does not read worktrees. That is unrelated to this change; the CI uses a plain checkout.Notes
oss-parentwould fix every project at once. This PR covers this repository.🤖 Generated with Claude Code