Conversation
added 4 commits
September 18, 2026 18:20
# Conflicts: # src/verification/__init__.py # tests/unit/test_verification.py # workflow/rules/inference.smk
jonasbhend
reviewed
Sep 19, 2026
jonasbhend
left a comment
Contributor
There was a problem hiding this comment.
Hi @lclanzi. Very cool feature indeed.
I suggest we discuss if we want to ditch derived parameter computation in evalml in favor of using post-processors (and ignore sources for which derived parameters are unavailable). What do you think?
My second comment relates to direction of wind. For this, the standard verification metrics do not make sense (e.g. mean absolute error) and should be replaced with error metrics for circular quantities. I suggest to at least include a warning, or maybe ditch DD_10M for now and comment out the relevant sections.
Contributor
Author
|
Thanks for the feedback @jonasbhend! Yes, the idea is to compute all variables during inference, in order to minimize external operations. For DD_10M:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds wind speed (SP_10M), wind direction (DD_10M) and relative humidity (RELHUM_2M) as verifiable parameters,
SP_10M/DD_10M/RELHUM_2Mnatively from ML-inference GRIB. Derives them fromU_10M/V_10M/T_2M/TD_2Mfor baselines (ICON archive, INCA).RELHUM_2Mnatively from the DWH (ure200h0) instead of deriving it fromT_2M/TD_2MBIAS/MSE/MAE/CORRforDD_10M: a plain difference near due-north (e.g. 355° vs 5°) previously measured a 350° error instead of the true 10°.RELHUM_2Mcolormap default (viridis, 0-100%)