fix(eid-wallet): show the role once, and a real message for an unknown eName - #1165
Merged
Merged
Conversation
…n eName The details sheet printed the role as a badge and again as each entry's heading. The entry now repeats it only when it differs between entries or when it prefixes an awaiting note. resolveVaultUri threw "Registry could not resolve @…: 404", which scanLogic showed verbatim: internal wording, an HTTP status, and untranslated. It now throws an ENAME_NOT_FOUND code, callers word it from the message catalog, and the status stays in console.error.
Contributor
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
resolveVaultUri mapped every failed registry response to ENAME_NOT_FOUND, so a registry outage (500, or a proxy's 502/503) told the user the eID did not exist and to check a QR code that was fine. Any status other than 404 now throws REGISTRY_UNAVAILABLE, which callers word with the existing generic messages.
Sahil2004
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The social binding details sheet showed the role twice — as a badge and again as each entry's heading. It now appears once, and the entry repeats it only when bindings with that contact run in both directions, or when it prefixes an awaiting note.
Scanning a QR code for an eName that isn't in the registry showed
Registry could not resolve @…: 404— internal wording, an HTTP status, and untranslated.resolveVaultUrinow throws anENAME_NOT_FOUNDcode, following theCANCEL_NOT_PENDINGpattern from #1147; callers word it from the message catalog and the status stays inconsole.error.Issue Number
Closes #1160
Closes #1151
Type of change
Design decisions
Two catalog keys rather than one. The scan screen says "check the QR code"; the details sheet does not, because the same code surfaces there when cancelling an invite whose counterparty won't resolve, where no QR code is involved. Without the second mapping the raw sentinel string would have reached that error box.
The per-entry role is dropped on
!binding.mutuallySignedrather than the contact-levelpendingflag, so a contact with one confirmed and one pending binding still shows the role on the pending entry, where it prefixes the "· Awaiting confirmation" suffix.#1151 also suggests flagging the unknown eName on the review screen before the user taps Sign Binding. That is a larger change and is not included — worth a follow-up issue.
How the change has been tested
pnpm run checkclean.pnpm run testgreen for theeid-walletnode project, with two newresolveVaultUritests asserting the thrown code carries no HTTP status.The
storybookvitest project did not run: installing the Playwright browser hangs at extraction on this machine. It smoke-runssrc/**/*.stories.*for$lib/uiprimitives only, none of which this PR touches.Change checklist