Conversation
…language Didit renders its own UI, so the translations added in #1145 never reached the verification screens: a Russian user saw English from the moment verification started. Didit takes a `language` on session creation and supports both ru and uk under the same ISO 639-1 codes the app already uses. Without it Didit falls back to detecting the browser language, which does not work inside the Tauri webview. The locale has to travel from the wallet through the provisioner, so this touches both sides. The wallet sends its active locale on the four calls that open a session — ePassport, onboarding, the KYC upgrade overlay and account recovery — and evault-core forwards it to Didit. Anything that is not a plausible ISO 639-1 code falls back to `en` rather than being handed to Didit as-is. Recovery is the one that mattered most: someone recovering an account is already in trouble, and that was the worst place to drop them into English. Closes #1153
Contributor
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The identity verification screens come from Didit's hosted UI, so the translations in #1145 never reached them: a Russian or Ukrainian user saw English from the moment verification started.
Didit takes a
languageon session creation and supportsruandukunder the same ISO 639-1 codes the app already uses. We were omitting it, and Didit's fallback — detecting the browser language — does not work inside the Tauri webview.The locale has to travel from the wallet through the provisioner, so this touches both sides. The wallet sends its active locale on the four calls that open a session;
evault-coreforwards it to Didit.Issue Number
Closes #1153
Type of change
Fix (a change which fixes an issue)
How the change has been tested
pnpm checkineid-wallet(0 errors, 5 pre-existing warnings) andtscinevault-coreboth pass. 12 new unit tests cover the code validation.Not tested against Didit's API. The
languagefield is documented and the codes are confirmed supported, but nobody has watched a real session come up in Russian — worth one manual pass before this is relied on.Change checklist
Notes
/recovery/start-sessionrather than/verification/v2, so it needed handling separately.eninstead of being handed to Didit as-is. Format is checked rather than matched against a fixed list, so adding a wallet locale needs no change here.Docs: https://docs.didit.me/sessions-api/create-session