Repository navigation
Conversation
experiment.define read an arm's label and its two firmware versions and dropped everything else, so an arm defined with cad on ran with cad as the scenario had it, under a label saying otherwise. Arms are now decoded whole, held to the values experiment.vary accepts, and a field an arm does not have is refused with bad_params, leaving the arms already defined in place.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experiment.define read each arm's
label,repeater_versionandcompanion_versionand silently dropped the rest. An arm defined with"cad": "on"therefore ran with CAD as the scenario had it, labelled as though it were on, and its row compared two identical configurations.session.ExpArm, sopath_hash_mode,rep_path_hash,loop_detect,cad,spread_msandsetall reach provisioning.variedfunction experiment.vary uses, so the two verbs cannot disagree about what a value may be.cad_mode) or a bad value is refused withbad_params, and the arms already defined are kept.Tests:
define_test.go, two cases, both fail on main.verb-reference.mdregenerated.Manual: MeshBench/docs#48.