Fix photo naming expression returning NULL - #4671
Open
xkello wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 32861293003Coverage decreased (-0.009%) to 59.055%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 1 file lost coverage.
Coverage Stats
馃挍 - Coveralls |
馃摝 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a photo naming expression references a field that's blank, QGIS's
||concatenation returns NULL for the whole expression. This NULL wasn't caught before being used as a filename, producing invalid names (a leading space, no real name) that the server rejects on sync with no way to fix it from the app.Fixes: #4622
What changed
In
AttributeController::renamePhotos(), after evaluating and sanitizing the naming expression, an empty/NULL result is now detected before it's turned into a filename. In that case the rename is skipped and the file keeps its original, valid name instead.