Repository navigation
feat(playback): a Pool lights up as its first marker arrives, and a Converter shows a conversion mark (v0.23.0) - #342
Merged
Conversation
…onverter shows a conversion mark (v0.23.0) Part of #330 (PR 2 of 3). The cues inside a node, as a presentation layer only: the engine, the RNG, files, share links, digests, simulation results, node sizes and text placement are unchanged. - Pool arrival pulse: a soft tint of the silhouette from 7 px inside, under the title and value, from the moment the Pool's first token of the step arrives; a fixed 0.5 s, keyed on the step so the settle does not restart it. The value still changes at settle. Past the 24 pairs and at L0 it plays at the same moment. It replaces the disc that played at settle. - Conversion mark (option A): a 10 px two-arrow drawing inside the Converter from its onset while its tokens move, faded after the settle. Each Converter has its own spot, nearest the end of the mode text, at least 6 px inside the outline and clear of its text, computed once per text / language / font / size change; at L0 it takes the type dot's place. - Focus mode never dims either; reduced motion holds both static for the step; forced colours draw the pulse as a 2 px Highlight line under the text and the mark in the same colour. Docs: simulation-playback §PB2.1, new §PB4.7, §PB9; ordering §PBO3; large-graph-readability §LGR2.3; visual-language §VL9. One approved baseline replaced (run-distinction-states). Release notes v0.23.0 in 18 languages.
Deploying cozy-loop-studio with
|
| Latest commit: |
3f7203a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf8a26dc.cozy-loop-studio.pages.dev |
| Branch Preview URL: | https://feat-play-pool-converter.cozy-loop-studio.pages.dev |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #330: the second of its three playback pull requests (v0.23.0). Playback now shows what happens inside the nodes: a Pool lights up as its first marker arrives, and a Converter shows a conversion mark while its markers move, with their Focus, reduced-motion and forced-colours forms. A presentation layer only: the engine, the RNG, files, share links, digests, simulation results, node sizes and text placement are unchanged.
What changes
Highlightline 7–9 px inside the outline, under the text, and the mark takes the same colour.Contract changes
docs/simulation-playback.md: §PB2.1 (the Pool's inflow cue is the arrival pulse), the new §PB4.7 (pulse, mark, Focus, reduced motion, forced colours), §PB9 (the static forms).docs/simulation-playback-ordering.md§PBO3: the conversion mark; onsets unchanged.docs/large-graph-readability.md§LGR2.3: the pulse and the mark keep full strength.docs/visual-language.md§VL9: the new motion and its reduced-motion form.Tests
e2e/playback-node-cues.spec.ts, 10 tests: 7 behaviour tests and 3 regression tests.livefrom the Converter's onset, inside the drawn outline by 6 px and clear of its text, 10 px, and fades after the settleHighlightline 2 px wide under the text, the mark inHighlightsrc/components/nodes/convMark.test.ts: the spot is inside and clear, the nearest free one, follows the mode text, is stable,nullwhen nothing fits; the arrive-beat τ.e2e/canvas-refresh-edges.spec.ts: the reduced-motion arrival cue is now the pulse (.nodef__pulsefor.nodef__arrival); titles unchanged.Baselines
One replaced, approved after an off (main
c4640bc) / on (this branch) capture of all 76, compared on every channel, each side's desktop set captured twice to separate noise:large-graph-readabilityrun-distinction-states-chromium(under reduced motion the Store Pool holds the new inside tint where the old disc was). Four that differed were left as they are:frames-activity-chromium(the two handle rings of one connection re-rasterised; this baseline varies by more between two captures of main),matrix-light-L2-chromium(9 px at ±1 per channel),ko-long-label-and-tip-chromiumandko-desktop-app-chromium(the toolbar spot that varies between runs, 4 px at ±1). The other 71 are byte-identical.Checks run locally
npx tsc -b, unit tests 3,286 passed, every sourcecheck:*, oxlint at its 39-warning baseline.Release
v0.23.0:
package.json, the release-note entry (three lines in 18 languages, 16 without native review; the Portuguese lines are identical in pt-BR and pt-PT),.changes/playback-node-cues.json,CHANGELOG.md,README.md. The release date is set to the Seoul day of the merge right before it.