Use EnumerateDirectories in local triage cache walk - #65
Open
chryzsh wants to merge 1 commit into
Open
Conversation
Maintainer-requested in Mayyhem#61: swap the eager Directory.GetDirectories() call for Directory.EnumerateDirectories() in the recursive local triage cache walk, so recursion into the first child directory can begin without first materializing the full array of siblings. Same traversal order and output, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #61.
local triagewalks the client's ccmcache directory recursively, and it was usingDirectory.GetDirectories(), which grabs every subdirectory into a list before it processes any of them. This swaps it forDirectory.EnumerateDirectories(), which hands back directories one at a time as it finds them, so it can start recursing into the first one right away instead of waiting to list everything first. Same order, same output, nothing else changed.Type of Change
Testing
mainand this branch as merged binaries and ranlocal triageagainst a lab client'sC:\Windows\ccmcache— output was identical between the two, so no behavior changed.Test Configuration:
Bonus Points: