Repository navigation
test(linux): read broker descriptor tables without racing a worker that ends - #229
Merged
Merged
Conversation
A spare worker leaves once the request it was started for is served, and a thread that is ending reads an empty descriptor table before its task goes. The test now waits for such a thread to disappear and skips it, fails on an empty table of a thread that keeps running, and requires the home thread's table to be read.
lexoliu
changed the title
lexoliu
marked this pull request as ready for review
November 12, 2026 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The descriptor-table test read a broker thread's table as empty on ubuntu-24.04-arm, and
table_ofdropped the error. With the error reported, a rerun showed the case: aheel-brokerspare worker leaves its loop once the request it was started for is served (workin home.rs), and the test read its table while it was ending. The table of an ending thread lists nothing before its task goes away.table_ofnow fails on any read error except a descriptor closed mid-listing. On an empty table it waits for the thread to disappear and skips it, and it fails if the thread is still running. The test also requires the home thread's table to be read. The first failure named the home thread, which lives as long as the sandbox. If that happens again, it will now fail with its exact cause.Refs #228