Repository navigation
fix(linux): close the broker's copy of an opened file before the caller resumes - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broker answered a brokered open with
SECCOMP_ADDFD_FLAG_SEND, resuming the caller while its own copy of the descriptor was still open, so a script the caller had just written could failexecvewithETXTBSY. The descriptor is now installed without the flag, the broker's copy is dropped, and the answer carrying the installed number is sent after; the filter'sWAIT_KILLABLE_RECVkeeps the caller waiting across both steps. A broker test writes and runs a script 200 times in a row.Closes #226