Repository navigation
fix(webfetch): give Chrome's first start on a machine the time it takes - #771
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chromiumoxide's default 20 s launch timeout was the bound for Chrome printing its DevTools address. The first start on a fresh machine takes 10-13 s on a GitHub runner when it succeeds and sometimes past 20 s; later starts take under half a second, so the failing test was always the first headless one. The launch timeout is now 60 s, with where the number comes from beside it; a Chrome that exits is still reported at once.
Closes #770