Repository navigation
docker: start the MCP server by default (fixes Glama build) - #41
Merged
Merged
Conversation
The image ran `aisync --help` and installed without the mcp extra, so a host that launches the container with no arguments and speaks MCP over stdio (Glama build and score) got an exit code of 2 and "the MCP server needs the official SDK". Install .[mcp] and make `mcp` the default command. CLI use still works: `docker run --rm ghcr.io/maxont/aisync --help`. Verified: docker build from this Dockerfile succeeds; the default run answers initialize and tools/list over stdio; `--version` prints aisync 0.2.10. Co-authored-by: MaxonT <[email protected]> Agent: claude-code
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image's default command was
aisync --helpand it installed without themcpextra, so a host that starts the container with no arguments and talks MCP over stdio failed with exit 2 ("the MCP server needs the official SDK"). This makesmcpthe default command and installs.[mcp].Verified locally:
docker buildsucceeds from this Dockerfile.docker run -ianswersinitializeandtools/listover stdio.docker run --rm <image> --versionprintsaisync 0.2.10.python3 -m unittest discover -s tests: 449 run, OK (skipped=1).tools/privacy_scan.py: 138 files, 0 hits.Not verified: the Glama build log itself (the admin page needs a sign-in, so I could not read the exact error there).