Skip to content

docker: start the MCP server by default (fixes Glama build) - #41

Merged
MaxonT merged 1 commit into
mainfrom
glama-build-fix
Nov 17, 2026
Merged

MaxonT merged 1 commit into
mainfrom
glama-build-fix

Conversation

@MaxonT

@MaxonT MaxonT commented Nov 17, 2026

Copy link
Copy Markdown
Owner

The image's default command was aisync --help and it installed without the mcp extra, so a host that starts the container with no arguments and talks MCP over stdio failed with exit 2 ("the MCP server needs the official SDK"). This makes mcp the default command and installs .[mcp].

Verified locally:

  • docker build succeeds from this Dockerfile.
  • Default docker run -i answers initialize and tools/list over stdio.
  • docker run --rm <image> --version prints aisync 0.2.10.
  • python3 -m unittest discover -s tests: 449 run, OK (skipped=1).
  • tools/privacy_scan.py: 138 files, 0 hits.

Not verified: the Glama build log itself (the admin page needs a sign-in, so I could not read the exact error there).

The image ran `aisync --help` and installed without the mcp extra, so a host
that launches the container with no arguments and speaks MCP over stdio (Glama
build and score) got an exit code of 2 and "the MCP server needs the official
SDK". Install .[mcp] and make `mcp` the default command. CLI use still works:
`docker run --rm ghcr.io/maxont/aisync --help`.

Verified: docker build from this Dockerfile succeeds; the default run answers
initialize and tools/list over stdio; `--version` prints aisync 0.2.10.

Co-authored-by: MaxonT <[email protected]>
Agent: claude-code
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T00:29:13.359861Z 2908b2d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@MaxonT
MaxonT merged commit 14b6c4b into main Nov 17, 2026
6 checks passed
@MaxonT
MaxonT deleted the glama-build-fix branch November 17, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant