Repository navigation
Make constructor inspection warnings advisory - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RMS reports an unrecognized constructor for a public Rust type as a warning, but that warning still causes strict audit and module-scoped checks to require review. Treat this inspection uncertainty as advisory, matching unresolved calls and imports. Retain the diagnostic and keep errors, canonical requirements, and native proof strict.
The patch changes one diagnostic classification and documents the consumer acceptance policy. It does not change the analyzer, manifests, schemas, or BeepBeep.
Validation: seven focused native tests passed across three commands (all exit 0), including real constructor diagnostics, mixed audit/scoped results, known forbidden effects, and native compilation/test failures. Formatting and diff checks passed. Required hosted CI remains the merge gate.