Repository navigation
symbiont: let api_doc/api_index read paths the way a model writes the… - #83
Merged
Merged
Conversation
…m, and suggest the closest names when one does not resolve
render_doc now cleans the query (backticks, a leading item keyword, generic
arguments, a trailing `()` or `!`), then tries the path as given, then with
its leading segments dropped, then `Type::member` as the type, then a unique
name that differs only in case. Each fallback answer starts with a note on the
path to use. render_index on a dependency crate name lists the prelude items
from that crate. A path that still does not resolve gets up to 5 closest
names (case-insensitive containment, then edit distance within a third of the
name) in the error. This changes DocIndexError::{ItemNotFound, ModuleNotFound}
to carry a Closest.
…w carry a Closest, which breaks downstream matches and constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m, and suggest the closest names when one does not resolve
render_doc now cleans the query (backticks, a leading item keyword, generic arguments, a trailing
()or!), then tries the path as given, then with its leading segments dropped, thenType::memberas the type, then a unique name that differs only in case. Each fallback answer starts with a note on the path to use. render_index on a dependency crate name lists the prelude items from that crate. A path that still does not resolve gets up to 5 closest names (case-insensitive containment, then edit distance within a third of the name) in the error. This changes DocIndexError::{ItemNotFound, ModuleNotFound} to carry a Closest.