Skip to content

symbiont: make Runtime::build_and_register public - #81

Merged
MathisWellmann merged 1 commit into
mainfrom
build-reg
Sep 26, 2026
Merged

MathisWellmann merged 1 commit into
mainfrom
build-reg

Conversation

@MathisWellmann

Copy link
Copy Markdown
Owner

No description provided.

…gister known source without the LLM (e.g. to resume from a checkpoint)
@github-actions

Copy link
Copy Markdown

Summary

The PR widens Runtime::build_and_register from pub(crate) to pub and adds a doc paragraph plus an # Errors section for the new host-facing use case. All types in the signature (Runtime, BuildRecord, Revision, Result) are already re-exported from lib.rs, so the visibility change itself is consistent; the one issue is the new error contract.

Issues

  • symbiont/src/runtime.rs:899 — Major: the new # Errors section lists only compile failure and dylib load failure, but the body can also return Error::Io (e.g. std::fs::copy at line ~974 and std::fs::metadata) and Error::MutexPoison (the revisions RwLock reads/writes), so a host writing error handling against the documented contract will misclassify or unreachable! on real outcomes. List the Io and MutexPoison outcomes (or phrase it as "compiling or loading the dylib, or internal I/O/lock failure") in the # Errors section.

@MathisWellmann
MathisWellmann merged commit d02abc6 into main Sep 26, 2026
8 of 11 checks passed
@MathisWellmann
MathisWellmann deleted the build-reg branch September 26, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant