Repository navigation
fix: Remove multi-framework target from SensitiveFlow.Tool - #3
Merged
Merged
Conversation
…TargetLatestRuntimePatch to false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the v1.0.0-preview.3 release workflow failure. The
dotnet packstep was attempting to publish binaries for net8.0 and net9.0 that don't exist, because SensitiveFlow.Tool is a CLI tool that only needs to target net10.0.Root cause: The
Directory.Build.propsdefinesTargetFrameworks=net8.0;net9.0;net10.0globally for all projects. TheSensitiveFlow.Tool.csprojdefined onlyTargetFramework=net10.0, but MSBuild wasn't correctly overriding the global property, causing it to attempt compilation for frameworks that don't exist.Solution: Add
<TargetFrameworks></TargetFrameworks>(empty) before<TargetFramework>net10.0</TargetFramework>to ensure the global property is overridden.Type of change
Related regulatory/privacy requirement (if applicable)
N/A
Checklist
CHANGELOG.mdupdated