Repository navigation
Conversation
`Machine::register_schema` answered from cached state, which can predate another process's `compare_and_evolve_schema`. The writer then saw its evolved schema as unregistered and `compare_and_append_batch` panicked with "fetching a schema id should only fail when the shard is tombstoned", e.g. on a replica creating an index right after `ALTER TABLE ... ADD COLUMN`. Closes: PER-130 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine::register_schemaanswered from cached state, which can predate another process'scompare_and_evolve_schema. The writer then saw its evolved schema as unregistered andcompare_and_append_batchpanicked with "fetching a schema id should only fail when the shard is tombstoned", e.g. on a replica creating an index right afterALTER TABLE ... ADD COLUMN.Nightly run: https://buildkite.com/materialize/nightly/builds/18698 (edit: still fails in upgrade tests because we run the old code there) & https://buildkite.com/materialize/nightly/builds/18699 (edit: green (modulo the other failure fixed in another PR))
Closes: PER-130