Repository navigation
fix: ignore tzdata in deptry unused dependency check - #1945
Merged
Merged
Conversation
tzdata provides the IANA time zone database for zoneinfo on Windows and is a data-only package with no importable module, so deptry's DEP002 check flagged it as an unused dependency. Add a per-rule ignore so the check-dependencies CI job passes. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
check-dependenciesCI job (deptry) started failing after #1938 replacedpytzwith the stdlibzoneinfoand addedtzdataas a Windows-only runtime dependency:tzdatais a data-only package (the IANA time zone database) with no importable module. It is used implicitly byzoneinfoon Windows, so it is never imported directly — which is exactly what deptry's DEP002 rule flags.Fix
Add a
[tool.deptry.per_rule_ignores]entry sotzdatais excluded from the DEP002 unused-dependency check.Verified locally with
uv run deptry src→ Success! No dependency issues found.Follow-up to #1938. The failing CI was observed on the release-please PR #1939.