Update markdown-it-attrs version - #2907
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2907 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 133 133
Lines 7234 7234
Branches 1682 1650 -32
=======================================
Hits 5160 5160
Misses 2068 2068
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gerteck
approved these changes
Jul 28, 2026
Member
There was a problem hiding this comment.
LGTM! Verified that the solution works, no error on minimal reproduction suggested by @Harjun751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Closes #2905
Overview of changes:
Bumped
markdown-it-attrsfrom^4.1.3to^5.0.1.Markbind's inline markdown rendering path (
MarkdownProcessor.renderMdInline, used for include-panel processing) callsmd.renderInline(). When inline source has a trailing{.class}attribute pattern (e.g.Some text{.text-danger}), markdown-it-attrs' "end of block" pattern transform walks past end of the token array looking for a surrounding block token, it then throws error and the plugin swallows the error by printing it toconsole.errorwhile silently dropping the attribute.This issue was fixed upstream in markdown-it-attrs v5.0.1 (arve0/markdown-it-attrs#184), which bounds-checks the token walk and returns early instead of erroring.
v5.0.0 also changed fenced-code-block attribute placement (moves attrs from
<code>to the outer<pre>by default, via a newfenceAttrsOnPreoption). This does not affect us as markbind registers its own customfencerenderer so it overrides the plugin's fence renderer regardless of that option.Anything you'd like to highlight/discuss:
Testing instructions:
Render a page/include with inline text containing a trailing
{.class}attribute (e.g.Some text{.text-danger}) through a path that hitsrenderInline. Confirm no error printed and class is applied to the output.Alternatively, try running
markbind buildon the following repo: git-mastery.github.ioProposed commit message: (wrap lines at 72 characters)
Bump markdown-it-attrs to 5.0.1 to fix renderInline error
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):