chore: retire surface-priors S2L1CGeeSource in favour of bestpixel (v… - #4
Merged
Merged
Conversation
…0.7.0) The L1C custom-AC composite now ships in the published `bestpixel` package (bestpixel.build_l1c_composite, since bestpixel 0.2.0), so the duplicate implementation added to surface-priors in 0.6.0 is removed: - delete sources/s2_l1c_gee.py (S2L1CGeeSource) and atmosphere.py - revert sources/s2.py (drop S2_L1C_* constants + aod_cloud_score_to_quality), types.py (DEFAULT_S2_L1C_BANDS), cli.py (--gee-product s2_l1c / --atmosphere-sidecar / --low-aod-frac) to their pre-0.6.0 state - drop the L1C tests (test_atmosphere.py, test_s2_l1c_gee.py, and the aod-quality cases in test_s2_helpers.py) - scripts/run_l1c_composite.sh: stage 4 now calls bestpixel.build_l1c_composite surface-priors keeps the S2 L2A GEE source and everything else unchanged. 88 tests pass, ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…0.7.0)
The L1C custom-AC composite now ships in the published
bestpixelpackage (bestpixel.build_l1c_composite, since bestpixel 0.2.0), so the duplicate implementation added to surface-priors in 0.6.0 is removed:surface-priors keeps the S2 L2A GEE source and everything else unchanged. 88 tests pass, ruff clean.