Fix a crash in single-argument mode, add param dumping - #537
Merged
JanuszBedkowski merged 1 commit intoSep 23, 2026
Merged
Conversation
…p-default-params Running `lidar_odometry_step_1 <input_folder>` read argv[3], which does not exist, so the results path was garbage. It now saves into the next free `<input_folder>/lio_result_N`, like the GUI, and exits with an error if the folder holds no Mandeye data. `lidar_odometry_step_1 --dump-default-params <file.toml>` writes the default parameters to a file and exits, so you can edit them and run headless without opening the GUI. The help text lists both options. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
michalpelka
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
lidar_odometry_step_1 <input_folder>read argv[3], which does not exist, so the results path was garbage. It now saves into the next free<input_folder>/lio_result_N, like the GUI, and exits with an error if the folder holds no Mandeye data.lidar_odometry_step_1 --dump-default-params <file.toml>writes the default parameters to a file and exits, so you can edit them and run headless without opening the GUI. The help text lists both options.