Repository navigation
Fix registry quarantine provenance and MCP dependency crash - #54
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Andre Schu <[email protected]>
Co-authored-by: Andre Schu <[email protected]>
1 of 3 tasks
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
.jsonfile under theregistry_fetchquarantine layout could act as both the registry snapshot payload and its own sidecar metadata. With operator approval/consent,apply_merge()accepted it and merged untrusted pattern records, bypassing the intended requirement that merge inputs are.txtcontent files produced byscp_fetch_registry.mcp 2.x, butscp.antigen_mcpimports the MCP 1.xmcp.server.fastmcpAPI, causing Antigen MCP import/startup failure.Root cause
_load_quarantine_snapshot()verified the path was underregistry_fetch/and that sidecarreason=registry_fetch, but did not require the merge input path to be a.txtcontent file. For a.jsonpayload,with_suffix('.json')pointed back to the same file.pyproject.tomldeclaredmcp>=1.2.0without an upper bound despite the code using the pre-2.0 FastMCP API.Fix
.txtregistry-fetch quarantine merge inputs withquarantine_provenance_rejected..jsonpayloads.mcp>=1.2.0,<2.0.0.Validation
PYTHONPATH=src python3 -m pytest tests/test_registry_ssot.py::test_apply_merge_rejects_json_payload_self_certifying_as_sidecar -qfailed before the fix because the forged payload merged.PYTHONPATH=src python3 -m pytest tests/test_registry_ssot.py tests/test_registry_fetch_r4.py tests/test_registry_load_order_r5.py tests/test_appsec_antigen_mcp_gates.py -q-> 47 passed.python3 -m compileall -q src/scp && git diff --check-> passed.PYTHONPATH=src python3 -m pytest -qwas also run: 351 passed / 3 skipped / 7 failed. The failures were existing unrelated baselines: contract hash mismatches, RT11 residual, and optionalcoincurvesetup tests without antigen extras.