Repository navigation
Fix registry quarantine provenance and MCP dependency bound - #51
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Andre Schu <[email protected]>
Co-authored-by: Andre Schu <[email protected]>
1 of 3 tasks
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
.jsonfile under theregistry_fetch/quarantine layout could act as both the merge payload and sidecar metadata by including top-levelreason: registry_fetch, allowingapply_merge(..., approve=True)to accept a file that was not the.txtcontent path produced byscp_fetch_registry.mcp2.x even though the code imports the v1mcp.server.fastmcp.FastMCPAPI, breaking MCP entrypoints and the contract test collection path.Root cause
_load_quarantine_snapshotvalidated that a path resolved under the registry-fetch quarantine directory, but did not require the content path to use the.txtquarantine payload suffix before checking the sibling.jsonsidecar.mcp>=1.2.0, including the incompatible 2.x API.Fix
.txtcontent paths, so a JSON file cannot satisfy its own sidecar provenance check.mcp>=1.2.0,<2in bothpyproject.tomlandrequirements.txt.Validation
PYTHONPATH=src python3 -m pytest tests/test_registry_ssot.py::test_apply_merge_rejects_json_payload_as_its_own_sidecar -qfailed because the forged payload merged.PYTHONPATH=src python3 -m pytest tests/test_registry_ssot.py tests/test_appsec_fetch_body_caps.py tests/test_appsec_antigen_mcp_gates.py tests/test_mcp_contract_v1.py -q-> 46 passed.