Skip to content

chore: update dependencies + adapt calendar tests#4211

Merged
rejas merged 2 commits into
MagicMirrorOrg:developfrom
KristjanESPERANTO:deps
Jul 20, 2026
Merged

chore: update dependencies + adapt calendar tests#4211
rejas merged 2 commits into
MagicMirrorOrg:developfrom
KristjanESPERANTO:deps

Conversation

@KristjanESPERANTO

@KristjanESPERANTO KristjanESPERANTO commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

I updated dependencies (including node-ical to 0.27.0), which broke 2 tests. It's not a bug in node-ical, our code, or the tests - node-ical just switched its CJS build to non-configurable getters, so vi.spyOn on the module could no longer redefine them. I adjusted the two affected tests to use real invalid input instead of mocking, keeping the original test intention. No production code changes. Full suite passes again.

@rejas
rejas merged commit 469f3bf into MagicMirrorOrg:develop Jul 20, 2026
13 checks passed
@KristjanESPERANTO
KristjanESPERANTO deleted the deps branch July 20, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants