Repository navigation
Replace internal-only DataStructures containers with the standard library (std migration, stage 1) #59
Description
Follow-up to #50 / #58. First of three stages replacing RakNet's homegrown DataStructures::* containers (Source/include/mafianet/ds_*.h) with the C++ standard library. This stage touches only containers that never appear in a public signature, so it is API-neutral and can land on its own.
Scope
Containers whose only consumers are inside the library:
| Container | Consumers | Likely replacement |
|---|---|---|
DataStructures::RangeList |
reliability_layer.{h,cpp} (ack ranges) |
std::vector of ranges, or keep a small purpose-built type |
DataStructures::BPlusTree |
reliability_layer.h (split-packet channel lookup) |
std::map / std::unordered_map |
DataStructures::Heap |
reliability_layer.h (resend ordering) |
std::priority_queue |
DataStructures::LinkedList |
reliability_layer.{h,cpp} |
std::list or std::deque |
DataStructures::Multilist |
udp_proxy_coordinator.{h,cpp}, udp_proxy_client.h |
std::vector + std::unordered_map |
DataStructures::WeightedGraph, Tree, HuffmanEncodingTree* |
no DataStructures:: use left outside their own headers (connection_graph2.h includes but does not use WeightedGraph) |
delete after confirming |
Out of scope here and in every stage: MemoryPool, ThreadsafeAllocatingQueue and Page are allocators wired to rakMalloc/file-and-line tracking, not containers; Table is the in-memory database behind the SQL plugins. They stay.
Approach
- One container per commit, each landing green on the full suite (
ctest -L unitand-L integration, Linux Debug and Release in Docker since the reliability layer is involved). - Before replacing, check for semantics the standard type lacks:
RemoveAtIndexFastswap-removal, explicit capacity on the ring-bufferQueue, comparator function pointers onOrderedList,RangeListmerge behaviour. - The reliability layer is performance-sensitive: record before/after numbers from the loopback throughput integration tests and the hermetic
ReliabilityLayerharness in the PR. - Delete each
ds_*.honce its last consumer is gone;ds_weighted_graph.h,ds_tree.hand the Huffman factory look deletable immediately.
Acceptance
- No
DataStructures::use of the listed containers remains underSource/. - Public headers are byte-for-byte unchanged in their declarations (verified by diffing
include/mafianet/*.hsignatures). - Full suite green on Linux (Debug, Release), macOS, Windows.
- Throughput numbers recorded in the PR, no regression beyond noise.
Tracking: this is stage 1 of three. Stage 2: #60. Stage 3 (API break): #61.
Activity
refactor(ds): std container migration stage 1 (#59)