Repository navigation
Benchmarks: correct overclaims and counterbalance the method - #15
Merged
Merged
Conversation
…n the benchmark Odd runs start with pgqueue, even runs with Celery; a configurable pause (default 30 s) separates the two systems of a pair. Every record stores its position and the 1-minute load before and after. results.json gets schema_version 2 and keeps load_1min, so v1 readers still work.
… schema 1 results
…ncy per system, state the durability difference
…xtend the caveats, document the schema 2 method
… 1 and 2 workers, add durability and latency definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An independent review of #14 found the benchmark write-up overstated the comparison.
Text (README, docs/benchmarks.md)
Method (bench/bench.py)
Only
make bench-quickwas run as a smoke test. The full benchmark was not rerun: the machine is loaded by other jobs. Rerun withmake bench ARGS="--runs 6"on a quiet machine.