Repository navigation
fix: touch-only joystick and slide activation via double-tap jump - #60
Merged
Merged
Conversation
theghost1980
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
shouldUseMobileControls) that also checks pointerpointerTypeand returns false on non-touch pointers.destroyMobileControls()and call it when mobile controls are not allowed to ensure joystick and touch jump UI are not created or are removed on resize.MOBILE_JUMP_DOUBLE_TAP_WINDOW_MS,lastJumpTapTime, andhandleJumpButtonTap) so a two-tap on the touch jump button activatesactivateSlideMax()only whenfishPowerCount === FISH_MAX_POWERandslideActiveis false, while single taps still perform a normal jump.Testing
npm run typecheckand it completed successfully.npm run buildand it completed successfully (build emitted a chunk-size warning only).Codex Task