Repository navigation
fix: touch controls only on mobile and enable slide via jump+direction - #59
Merged
theghost1980 merged 1 commit intoFeb 8, 2026
Conversation
theghost1980
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fishPoweris full, matching desktop double-tap slide behavior without changing keyboard controls.Description
shouldUseMobileControlstothis.sys.game.device.input.touch === true || viewportWidth < 700so joystick and touch jump are only created on touch/small screens.mobileControlsEnabledis true.joystickStrengthandlastMoveDirectionChangeTimeplus constantsMOBILE_SLIDE_TRIGGER_DEADZONEandMOBILE_SLIDE_STABLE_MS, and updateupdateJoystick/resetJoystickto track direction strength and stability.tryJumpto acceptoptions: { fromTouch?: boolean }, call it from the touch jump hitbox with{ fromTouch: true }, and addshouldTriggerTouchSlideMax()to triggeractivateSlideMax()only whenfishPowerCount === FISH_MAX_POWERand the directional input passes deadzone or stability checks.Testing
npm run typecheckand it completed successfully.npm run buildand the production build completed successfully.Codex Task