Repository navigation
TwoSampleMR 0.7.13 - #696
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_outcome_data()in its example (thanks @hdraisma, Unsure re [Multivariable MR](https://mrcieu.github.io/TwoSampleMR/articles/perform_mr.html#multivariable-mr-1) documentation: ("Re-")extract clumped SNPs from exposures, or from outcome? #340)harmonise_ld_dat(), and hencedat_to_MRInput(get_correlations = TRUE), failing when the LD matrix SNPs were in a different order to the summary data; the LD matrix is now reordered to match (thanks @marwaalarab, Error in harmonise_ld_dat(x, ld) #348)mr_report()reports; p-values are now shown to 3 significant figures (thanks @sonia-shah, p-value format #42)run_mrmix()now removes SNPs with aneaf.exposurethat is missing or not strictly between 0 and 1, with a warning, instead of erroring inMRMix::standardize()(MRMix issue #169)mr_mode(),mr_simple_mode(),mr_weighted_mode(),mr_simple_mode_nome(), andmr_weighted_mode_nome()) now remove SNPs with abeta.exposureof 0, with a warning, instead of erroring with "non-finite 'bw'" indensity()(thanks @Julie1130, [BUG]: Error in density.default(BetaIV.in, weights = weights, bw = h) : non-finite 'bw' #570)mv_multiple()andmv_residual()withinstrument_specific = FALSE(the default), thensnpcolumn now reports the number of SNPs used in the analysis, which is all the SNPs, rather than the number passingpval_thresholdfor each exposure. Inmv_residual()this also fixes estimates being set toNAwhen few SNPs passedpval_thresholdfor an exposure, even though all SNPs were used (thanks @MaVdb and @mvab, Multivariable MR - P value threshold #78)effective_n()to give its formula, explain that it is half the effective sample size used by METAL, and where it is used in the package (thanks @carbocation, effective_n: off by factor of 2? #433)