Repository navigation
ci(release): don't bundle Windows system DLLs in extended dist - #3173
Merged
Merged
Conversation
ucrtbase.dll, msvcrt.dll and msvcp_win.dll are OS components. On Windows 10+ the system UCRT is always loaded over an app-local copy, msvcrt.dll is a KnownDLL, and msvcp_win.dll is an OS-internal runtime resolved from System32. None are redistributable from System32. Keep the VC++ redistributable DLLs (MSVCP140, VCRUNTIME140[_1]). Closes MODFLOW-ORG#3096 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop copying
ucrtbase.dll,msvcrt.dllandmsvcp_win.dllfromSystem32into the Windows extended distribution. These are OS components that Windows loads from the system directory regardless:None of them are redistributable anyway. Keep the redistributable DLLs (
MSVCP140,VCRUNTIME140,VCRUNTIME140_1).See:
Close #3096.