Skip to content

ci(release): don't bundle Windows system DLLs in extended dist - #3173

Merged
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:rm-win-system-dlls
Nov 16, 2026
Merged

wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:rm-win-system-dlls

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Stop copying ucrtbase.dll, msvcrt.dll and msvcp_win.dll from System32 into the Windows extended distribution. These are OS components that Windows loads from the system directory regardless:

  • ucrtbase.dll: on Windows 10+ the system UCRT is always used, even if an app-local copy is present (docs).
  • msvcrt.dll: a KnownDLL, always loaded from the system copy (docs).
  • msvcp_win.dll: OS-internal C++ runtime, pulled in transitively by system DLLs and resolved from System32.

None of them are redistributable anyway. Keep the redistributable DLLs (MSVCP140, VCRUNTIME140, VCRUNTIME140_1).

See:

Close #3096.

ucrtbase.dll, msvcrt.dll and msvcp_win.dll are OS components. On
Windows 10+ the system UCRT is always loaded over an app-local copy,
msvcrt.dll is a KnownDLL, and msvcp_win.dll is an OS-internal runtime
resolved from System32. None are redistributable from System32.
Keep the VC++ redistributable DLLs (MSVCP140, VCRUNTIME140[_1]).

Closes MODFLOW-ORG#3096

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added dependencies Dependency changes ci Continuous integration labels Nov 16, 2026
@wpbonelli
wpbonelli merged commit 3785fe5 into MODFLOW-ORG:develop Nov 16, 2026
10 of 19 checks passed
@wpbonelli
wpbonelli deleted the rm-win-system-dlls branch November 16, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration dependencies Dependency changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove system DLLs from Windows extended distribution?

1 participant