Skip to content

test(compare): read the closure criteria from .ims6 files - #3171

Merged
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
jdhughes-dev:test-compare-ims6
Nov 16, 2026
Merged

wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
jdhughes-dev:test-compare-ims6

Conversation

@jdhughes-dev

Copy link
Copy Markdown
Contributor

The comparison helpers get_dvclose and get_rclose read only IMS files ending in .ims, so a model whose IMS file ends in .ims6 kept the default head and budget tolerances instead of five times its OUTER_DVCLOSE and INNER_RCLOSE. Of the external test models, only test028_sfr_rewet is affected: its head tolerance becomes 0.005 for an OUTER_DVCLOSE of 0.001. That model failed the head comparison in #3160 by 0.00127 m on Linux and Windows, within its solver closure, because its rewetting is sensitive to roundoff.

Checklist of items for pull request

For additional information see instructions for contributing and instructions for developing.

get_dvclose and get_rclose read only files ending in .ims, so models whose
IMS file ends in .ims6 kept the default head and budget tolerances instead
of five times their OUTER_DVCLOSE and INNER_RCLOSE. Of the external test
models, this changes only test028_sfr_rewet, whose head tolerance becomes
0.005 for its OUTER_DVCLOSE of 0.001.

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@wpbonelli
wpbonelli merged commit 993ef9c into MODFLOW-ORG:develop Nov 16, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants