Repository navigation
test(compare): read the closure criteria from .ims6 files - #3171
Merged
Merged
Conversation
get_dvclose and get_rclose read only files ending in .ims, so models whose IMS file ends in .ims6 kept the default head and budget tolerances instead of five times their OUTER_DVCLOSE and INNER_RCLOSE. Of the external test models, this changes only test028_sfr_rewet, whose head tolerance becomes 0.005 for its OUTER_DVCLOSE of 0.001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison helpers
get_dvcloseandget_rcloseread only IMS files ending in.ims, so a model whose IMS file ends in.ims6kept the default head and budget tolerances instead of five times its OUTER_DVCLOSE and INNER_RCLOSE. Of the external test models, onlytest028_sfr_rewetis affected: its head tolerance becomes 0.005 for an OUTER_DVCLOSE of 0.001. That model failed the head comparison in #3160 by 0.00127 m on Linux and Windows, within its solver closure, because its rewetting is sensitive to roundoff.Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.For additional information see instructions for contributing and instructions for developing.