Repository navigation
perf(ims): sum each row in a local variable in lusol - #3146
Open
jdhughes-dev wants to merge 2 commits into
Open
jdhughes-dev wants to merge 2 commits into
jdhughes-dev wants to merge 2 commits into
Conversation
Contributor
Author
Reviewer Summary
|
jdhughes-dev
force-pushed
the
ilu-lusol-accumulate
branch
from
November 16, 2026 09:13
e2d9496 to
82148ae
Compare
lusol, which applies the ILUT and MILUT preconditioners, accumulated each row of the forward and backward solves in x(i). Because x(i) can alias x(jlu(k)), the compiler stored and reloaded x(i) for every term. Each row is now summed in a local variable and stored once. The order of operations is unchanged, so results are bit-identical, and the routine can still be called in place. Adds unit tests that lusol solves a tridiagonal system that ILUT and MILUT factor exactly, and that it matches the original algorithm to the bit for an inexact factorization, including in place. Refs MODFLOW-ORG#3145
A bare underscore in PRECONDITIONER_LEVELS stops the LaTeX release notes build.
jdhughes-dev
force-pushed
the
ilu-lusol-accumulate
branch
from
November 16, 2026 14:26
82148ae to
d6a2f51
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lusol, which applies the ILUT and MILUT preconditioners, summed each row of the forward and backward solves inx(i), which the compiler stored and reloaded for every term. Each row is now summed in a local variable, which makes the linear solve 39 to 45 percent faster per inner iteration with COMPLEXITY COMPLEX, with results unchanged to the bit.Checklist of items for pull request
fprettifyFor additional information see instructions for contributing and instructions for developing.