Repository navigation
fix: harden archive extraction - #413
Merged
Merged
Conversation
- extract tarballs with filter="data" to reject traversal, absolute paths, and escaping links - mask zip member modes to 0o777 so archives can't set setuid/setgid/sticky Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check yaml/toml loading for vulnerabilities, it's fine (
yaml.safe_loadandtomlieverywhere), but archive extraction had a couple gapsfilter="data"indownload_and_unzipto reject../paths, absolute paths, and links escaping the target dir. Python 3.11-3.13 doesn't filter by default0o777inMFZipFile, so an archive can't set setuid/setgid/sticky bits