Skip to content

fix(programs): fix multiple programs API bugs - #412

Merged
wpbonelli merged 2 commits into
MODFLOW-ORG:developfrom
wpbonelli:fix/programs-api-bugs
Nov 10, 2026
Merged

wpbonelli merged 2 commits into
MODFLOW-ORG:developfrom
wpbonelli:fix/programs-api-bugs

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fix some programs API bugs

  • strip leading v from version strings
  • compare versions semantically, so e.g. 1.5 == 1.5.00
  • install only binaries (executables and libraries), non-binary files were getting included
  • support double precision (...dbl) programs
  • support binaries that code.json doesn't directly mention e.g. mf5to6
  • raise instead of silently skipping unknown --subset names
  • write to .part files and then rename instead of directly overwriting
  • exclude draft releases from get_releases
  • only support latest if a non-draft release exists
  • say so if a repo has no releases

Also explicitly declare packaging and requests in the ecosystem dep group, these were installed transitively by pooch before

wpbonelli and others added 2 commits November 10, 2026 04:36
- Normalize recorded versions (strip leading v) and compare versions
  semantically in the ledger, so v1.5.1 == 1.5.1 and 1.5 == 1.5.00
- Install only executables/shared libraries from archives (skip LICENSE etc.)
- Make code.json double_switch *dbl variants and undescribed binaries
  (e.g. mf5to6) installable; error on unknown subset items
- get_releases excludes drafts, only offers 'latest' when a full release
  exists; get_release reports repos with no published releases
- Replace binaries via temp file + rename, cleaning up on failure
- Fix docs claiming mfnwt/vs2dt publish releases

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Both were only available transitively via pooch.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added the bug Something isn't working label Nov 10, 2026
@wpbonelli wpbonelli added this to the 1.10.0 milestone Nov 10, 2026
@wpbonelli wpbonelli changed the title fix(programs): versions, non-program files, dbl variants, release errors fix(programs): fix multiple programs API bugs Nov 10, 2026
@wpbonelli
wpbonelli merged commit 930c831 into MODFLOW-ORG:develop Nov 10, 2026
19 of 20 checks passed
@wpbonelli
wpbonelli deleted the fix/programs-api-bugs branch November 10, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant