Repository navigation
Conversation
The multi-line build command run by nick-fields/retry had no errexit, so a failed make-program call was masked by later successful commands. Release 30.0 shipped without any standard-precision source-built programs after the mp7 download failed (MODFLOW-ORG#84). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-line build command in the
nick-fields/retrystep had no errexit. Whenmake-programfailed on the mp7 download, the later--doublebuild andmake-code-jsonsucceeded, so the step exited 0 and release 30.0 was published without any of the standard-precision programs built from source.Add
set -euo pipefailso a failed command fails the step. Otherrun:steps already get-eo pipefailfrom theshell: bashdefault.Note that CI on this PR is expected to fail until the mp6/mp7 source URLs are fixed. That failure is the point. This would have prevented a broken release from going out as reported in #84