Repository navigation
ci(release): keep code.md and zipped code.json in sync with fetched versions - #81
Merged
Merged
Conversation
make-code-json writes both code.json and code.md from pymake's internal program catalog. patch_code_json.py corrected code.json to the versions actually fetched via releases.json, but code.md was left stale, and it is what feeds the release body and the README table. Regenerate code.md from the patched code.json in the same format pymake uses. Co-Authored-By: Claude Opus 5.5 <[email protected]>
patch_code_json.py appended the patched code.json to a zip that already contained make-code-json's copy, producing a duplicate entry whose resolution depends on the extracting tool, and left the stale copy in the app directory untouched. Rebuild the archive without the old entry, and overwrite the appdir copy via a new --appdir option. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…the zip Rather than letting make-code-json zip a stale code.json and then rebuilding the archive to replace it, run make-code-json without --zip and have patch_code_json.py add the corrected code.json once (every run, including when nothing changed). It fails if the zip already holds a code.json instead of writing a duplicate entry. Drop --appdir: the program directory is not distributed, so its stale copy does not matter. Document the metadata steps in DEVELOPER.md. Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pymake's
make-code-jsonwritescode.jsonandcode.mdfrom pymake's catalog, which can lag behind the versions fetched viareleases.json. This repo's scriptpatch_code_json.pycorrectedcode.jsonbut notcode.md, which feeds the release notes and README table. It also appended to a zip that already held pymake's stalecode.json, leaving a duplicate entry.Fixes:
patch_code_json.pyregeneratecode.mdfrom the patchedcode.jsonmake-code-jsonwithout--zip, makepatch_code_json.pyaddcode.jsonto the zip, and fail if one is already there