Repository navigation
Conversation
When a DayType has days of week, the ValidDayBits of its period were never turned into added/removed dates: the period loop rewrote the assignment reference in place, so the bits loop no longer recognised it. Also fixes an inverted EVERYDAY check and a dt.date() call on a date.
deryclem
added a commit
to deryclem/trenitalia-gtfs
that referenced
this pull request
Oct 20, 2026
Points vendor/badger at deryclem/badger fix-daytype-valid-day-bits (MMTIS/badger#195) so calendar_dates.txt is generated. Refs #1. Switch back to MMTIS/badger once the PR is merged.
skinkie
self-requested a review
October 21, 2026 06:29
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ValidDayBits of a period were never turned into added/removed dates when the DayType has days of week, so calendar_dates.txt came out empty. The period loop rewrote the assignment reference in place, so the bits loop never recognised it.
Checked on Trenitalia's and Italo's NeTEx, both from the Italian NAP: with Trenitalia the service days of all 17613 services now match the bits, and Italo's output is unchanged.