Repository navigation
Conversation
skinkie
approved these changes
Aug 21, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
copy_map reads via self.iter_only_objects(), so it needs to be called on
the storage holding the source data. gtfs_db_to_db calls it on db_write
instead of db_read, so PassengerStopAssignment/ScheduledStopPoint/StopPlace
etc. lose their outgoing references (or come out empty entirely).
epip_db_to_db.py does the same copy correctly (source_db.copy_map(...),
line 183).
Introduced in e5a8107 during the netexio -> mdbx migration, no test covers
this path. Same root cause as #101 (5t), also reproduced it converting
Trenitalia's NeTEx EPIP feed: stop_times.txt referenced 1935 stop_ids but
stops.txt came out empty.