Remove unused inputs - #132
Open
lrobion wants to merge 1 commit into
Open
Conversation
lrobion
force-pushed
the
remove-unused-inputs
branch
from
August 24, 2026 17:46
1fceef2 to
a8cbd66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All inputs not listed under "Bugs" in #121 are rejected by APCEMM and throw an error. Keys previously marked as deprecated are now promoted to throwing errors instead of warnings.
This is the "rip the bandaid" approach, we could have warnings instead but this forces this all changes in one go which I'd prefer. I can change this if needed.
Two notes:
When would we want to merge this @sdeastham given it will interfere with the current changes you are making?