Yaml path resolution - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116.
Previously relative paths were resolved against the location of the last input file to APCEMM leading to unexpected reading/failure to find of files.
Now relative paths in
input.yamlfiles passed to APCEMM are all resolved relative to the location of the input file that has set them.Other changes:
merged-input.yamlnow contains the absolute paths for paths passed in the inputdefaults/input.yamldoes not accept relative paths anymore (it ran into the aforementioned bug anyway before this fix)Output folder (string)is now required to be specified by the user (now set to=MISSING=indefaults/input.yaml), previously it would resolve to/path/to/last/input_yaml/passed/APCEMM_out/. In practice I think everyone would set this already, this just prevents unlikely bugs. This is a similar behavior to the met file input: the bare minimum valid APCEMMinput.yamlcontains a path to the met input and the path to the output.examples/default/which was completely out of date and theissl_rhi140/example covers it.Photolysis rates folder (string): /path/to/input/in default has not been fixed because it is unused and will be removed in #121.