Repository navigation
fix(auth): overwrite of password confirmation - #493
Open
monjiapawne wants to merge 2 commits into
Open
monjiapawne wants to merge 2 commits into
monjiapawne wants to merge 2 commits into
Conversation
monjiapawne
marked this pull request as ready for review
November 4, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Security.require_password_confirmationbeing turned back on for external auth.set_up_custom_authran last after all the other auth forms. When CustomAuth is disabled its cleanup branch overwrites with"Security.require_password_confirmation" true, but the other auth forms don't have local passwords.